Topics

A 4.17.5ish commit has made LRoute edits unable to be saved

Pete Cressman
 

After editing an LRoute Initializer, any save panel operation removes all settings.  Saves are OK on 4.17.4 and previous releases.

This must be an inadvertent error and although it's hard to resolve a negative question, if no one thinks its their commit,
I will look into it.

Pete
(waiting for no one's answer)

danielb987
 

Pete

Take a look at Issue #7504. It might be related.

Problem saving Logix conditionals
https://github.com/JMRI/JMRI/issues/7504

Daniel

2019-10-15 03:52 skrev Pete Cressman:

After editing an LRoute Initializer, any save panel operation removes
all settings. Saves are OK on 4.17.4 and previous releases.
This must be an inadvertent error and although it's hard to resolve a
negative question, if no one thinks its their commit,
I will look into it.
Pete
(waiting for no one's answer)
Links:
------
[1] https://jmri-developers.groups.io/g/jmri/message/2077
[2] https://groups.io/mt/34541350/1303822
[3] https://jmri-developers.groups.io/g/jmri/post
[4] https://jmri-developers.groups.io/g/jmri/editsub/1303822
[5] https://jmri-developers.groups.io/g/jmri/leave/defanged

Bob Jacobsen
 

If you have a particular set of the code (I.e. v4.17.4) that works and one that doesn’t (i.e. master), you can use `git bisect` to really rapidly find the commit that made the difference.

https://www.jmri.org/help/en/html/doc/Technical/GitFAQ.shtml

Bob

On Oct 14, 2019, at 6:52 PM, Pete Cressman <pete_cressman@...> wrote:

After editing an LRoute Initializer, any save panel operation removes all settings. Saves are OK on 4.17.4 and previous releases.

This must be an inadvertent error and although it's hard to resolve a negative question, if no one thinks its their commit,
I will look into it.

Pete
(waiting for no one's answer)
--
Bob Jacobsen
@BobJacobsen

Pete Cressman
 

I have to bail out on this (having spent the whole afternoon and getting zilch).

Problem 1 was 'git bisect' looking for jmri.lib.jinputvalidator-0.8.0.jar when running earlier versions (jmri.lib.jinputvalidator-0.6.0.jar was there, it seems 0.8.0 gets replaced) - so I can't pinpoint a precise commit.

Problem 2 was my understanding of DefaultConditionalManager/AbstractManager handling of register/deregister when "conditionalWhereUsed" is involved.

I can say after editing a conditional, everything is fine with the changes while the session continues.  However, at the store in DefaultConditionalManagerXml, the conditionals returned by cm.getNamedBeanSet() no longer have any of the edited conditionals present. (can't find how they get deregistered)

Sorry , but this is beyond my debugging ability.
Pete


On Tuesday, October 15, 2019, 07:49:51 AM PDT, Bob Jacobsen <rgj1927@...> wrote:


If you have a particular set of the code (I.e. v4.17.4) that works and one that doesn’t (i.e. master), you can use `git bisect` to really rapidly find the commit that made the difference.

https://www.jmri.org/help/en/html/doc/Technical/GitFAQ.shtml

Bob

> On Oct 14, 2019, at 6:52 PM, Pete Cressman <pete_cressman@...> wrote:
>
> After editing an LRoute Initializer, any save panel operation removes all settings.  Saves are OK on 4.17.4 and previous releases.
>
> This must be an inadvertent error and although it's hard to resolve a negative question, if no one thinks its their commit,
> I will look into it.
>
> Pete
> (waiting for no one's answer)

>

--
Bob Jacobsen
rgj1927@...





Dave Sand
 

Pete,

Issue #7504 has the details on a larger problem that also affects Logix in general and Sensor Groups which use Logix.

Dave Sand


----- Original message -----
From: Pete Cressman <pete_cressman@...>
To: jmri@jmri-developers.groups.io
Subject: Re: [jmri-developers] A 4.17.5ish commit has made LRoute edits unable to be saved
Date: Wednesday, October 16, 2019 12:26 AM



I have to bail out on this (having spent the whole afternoon and getting zilch).

Problem 1 was 'git bisect' looking for jmri.lib.jinputvalidator-0.8.0.jar when running earlier versions (jmri.lib.jinputvalidator-0.6.0.jar was there, it seems 0.8.0 gets replaced) - so I can't pinpoint a precise commit.

Problem 2 was my understanding of DefaultConditionalManager/AbstractManager handling of register/deregister when "conditionalWhereUsed" is involved.

I can say after editing a conditional, everything is fine with the changes while the session continues.  However, at the store in DefaultConditionalManagerXml, the conditionals returned by cm.getNamedBeanSet() no longer have any of the edited conditionals present. (can't find how they get deregistered)

Sorry , but this is beyond my debugging ability.
Pete




On Tuesday, October 15, 2019, 07:49:51 AM PDT, Bob Jacobsen <rgj1927@...> wrote:


If you have a particular set of the code (I.e. v4.17.4) that works and one that doesn’t (i.e. master), you can use `git bisect` to really rapidly find the commit that made the difference.


Bob

> On Oct 14, 2019, at 6:52 PM, Pete Cressman <pete_cressman@...> wrote:
>
> After editing an LRoute Initializer, any save panel operation removes all settings.  Saves are OK on 4.17.4 and previous releases.
>
> This must be an inadvertent error and although it's hard to resolve a negative question, if no one thinks its their commit,
> I will look into it.
>
> Pete
> (waiting for no one's answer)

>

--
Bob Jacobsen