|
Review request of #9098 - Refactor OBlock to use an enum instead of maps
Steve An enum class cannot extend another enum class. But you can simulate that behaviure. In LogixNG, I have an "enum" that I want to be extendable: https://github.com/danielb987/JMRI/blob/LogixNG_ne
|
Steve An enum class cannot extend another enum class. But you can simulate that behaviure. In LogixNG, I have an "enum" that I want to be extendable: https://github.com/danielb987/JMRI/blob/LogixNG_ne
|
By
danielb987
· #4468
·
|
|
Review request of #9098 - Refactor OBlock to use an enum instead of maps
When adding support of OBlock to LogixNG, I need to handle the different statuses that an oblock can have. And it's more reliable if it's handled by an enum than of constant strings. This PR adds an e
|
When adding support of OBlock to LogixNG, I need to handle the different statuses that an oblock can have. And it's more reliable if it's handled by an enum than of constant strings. This PR adds an e
|
By
danielb987
· #4464
·
|
|
Code changes to Tams to get it to compile
Hi, Not sure, but it could be that you need something like: return (TamsTurnoutManager) classObjectMap.computeIfAbsent(TurnoutManager.class, Class<? extends NamedBean> c) -> { return new TamsTurnoutMa
|
Hi, Not sure, but it could be that you need something like: return (TamsTurnoutManager) classObjectMap.computeIfAbsent(TurnoutManager.class, Class<? extends NamedBean> c) -> { return new TamsTurnoutMa
|
By
danielb987
· #4455
·
|
|
Testing Serial Port Code
Andrew, There is a short section about the shutdown manager here: https://www.jmri.org/help/en/html/doc/Technical/JUnit.shtml#ResetInstMgr See the sub section "Working with a ShutDownManager". You mig
|
Andrew, There is a short section about the shutdown manager here: https://www.jmri.org/help/en/html/doc/Technical/JUnit.shtml#ResetInstMgr See the sub section "Working with a ShutDownManager". You mig
|
By
danielb987
· #4449
·
|
|
Testing Serial Port Code
I'm no expert in mocking things, but I was able to mock the serial port and open it. I changed the code in GcSerialDriverAdapterTest and you can see my code in my branch: https://github.com/danielb987
|
I'm no expert in mocking things, but I was able to mock the serial port and open it. I changed the code in GcSerialDriverAdapterTest and you can see my code in my branch: https://github.com/danielb987
|
By
danielb987
· #4445
·
|
|
Codecov makes PRs more difficult to review
PR #9061 disables Codecov annotations for PRs. https://github.com/JMRI/JMRI/pull/9061 Daniel 2020-10-04 09:29 skrev danielb987:
|
PR #9061 disables Codecov annotations for PRs. https://github.com/JMRI/JMRI/pull/9061 Daniel 2020-10-04 09:29 skrev danielb987:
|
By
danielb987
· #4412
·
|
|
Codecov makes PRs more difficult to review
Is there a way to suppress these annotations for every file in every PR, for me as a GitHub user or for the JMRI project? I have looked at the settings page for my personal GitHub account and can not
|
Is there a way to suppress these annotations for every file in every PR, for me as a GitHub user or for the JMRI project? I have looked at the settings page for my personal GitHub account and can not
|
By
danielb987
· #4411
·
|
|
Review request of #9041 - System name validation / Manager Tests
Steve Young has done PR #9041 and it looks good to me. https://github.com/JMRI/JMRI/pull/9041 The PR adds validateSystemNameFormat() to some system specific managers and I don't know enough about thes
|
Steve Young has done PR #9041 and it looks good to me. https://github.com/JMRI/JMRI/pull/9041 The PR adds validateSystemNameFormat() to some system specific managers and I don't know enough about thes
|
By
danielb987
· #4406
·
|
|
Review request of #9033 - Split Multimeter into Meter
https://github.com/JMRI/JMRI/pull/9033 This PR does: * jmri.MultiMeter is split into jmri.Meter * jmri.VoltageMeter and jmri.CurrentMeter is added. * AmpMeterFrame and VoltMeterFrame are replaced by M
|
https://github.com/JMRI/JMRI/pull/9033 This PR does: * jmri.MultiMeter is split into jmri.Meter * jmri.VoltageMeter and jmri.CurrentMeter is added. * AmpMeterFrame and VoltMeterFrame are replaced by M
|
By
danielb987
· #4401
·
|
|
Jenkins jobs - disabling of 'PIT'
Hi, PR #9025 is now merged. Daniel 2020-09-19 18:11 skrev steve young via groups.io:
|
Hi, PR #9025 is now merged. Daniel 2020-09-19 18:11 skrev steve young via groups.io:
|
By
danielb987
· #4389
·
|
|
New icons for VoltMeterFrame/AmpMeterFrame?
I'm close to finish my work on split MultiMeter into Meter and as part of that, I'm replacing VoltMeterFrame/AmpMeterFrame with a common MeterFrame which can handle any VoltageMeter or CurrentMeter. T
|
I'm close to finish my work on split MultiMeter into Meter and as part of that, I'm replacing VoltMeterFrame/AmpMeterFrame with a common MeterFrame which can handle any VoltageMeter or CurrentMeter. T
|
By
danielb987
· #4382
·
|
|
Script for launching select unit tests
I think the main reason for why maven is slow is that it always recompiles the code. If I remember it correctly, it was Randall W who wanted that, while others argued against it. Now then Randall has
|
I think the main reason for why maven is slow is that it always recompiles the code. If I remember it correctly, it was Randall W who wanted that, while others argued against it. Now then Randall has
|
By
danielb987
· #4376
·
|
|
Script for launching select unit tests
Hi, That script may be useful. A simple way to test all tests in a package, that works on Windows, is: mvn test -Dtest="jmri.jmrit.beantable.LogixNGTableActionTest,jmri.jmrit.logixng.**.*Test" This co
|
Hi, That script may be useful. A simple way to test all tests in a package, that works on Windows, is: mvn test -Dtest="jmri.jmrit.beantable.LogixNGTableActionTest,jmri.jmrit.logixng.**.*Test" This co
|
By
danielb987
· #4374
·
|
|
What does JMRI actually do with Sensor PullUp/PullDown setting?
Swedish railways (the full scale railways, not model trains) uses one rail tied to ground and the other rail tied to power. The other end of the rail that's tied to power is tied to the coil of a rela
|
Swedish railways (the full scale railways, not model trains) uses one rail tied to ground and the other rail tied to power. The other end of the rail that's tied to power is tied to the coil of a rela
|
By
danielb987
· #4346
·
|
|
Reviewing
I have opened a new PR, #9001 - Multimeter, and requested your review on that PR. The PR is not ready for review yet, but I wanted to check if it was a temporary glitch that you didn't get a proper re
|
I have opened a new PR, #9001 - Multimeter, and requested your review on that PR. The PR is not ready for review yet, but I wanted to check if it was a temporary glitch that you didn't get a proper re
|
By
danielb987
· #4315
·
|
|
Reviewing
When you are requested to review a PR, you will get an email about it and that's probably what the email about PR 8998 was about. But yes, you will need to open the email to see what it's about. Thank
|
When you are requested to review a PR, you will get an email about it and that's probably what the email about PR 8998 was about. But yes, you will need to open the email to see what it's about. Thank
|
By
danielb987
· #4312
·
|
|
Codecov makes PRs more difficult to review
Matt Thanks a lot! Daniel 2020-09-03 13:35 skrev Matthew Harris:
|
Matt Thanks a lot! Daniel 2020-09-03 13:35 skrev Matthew Harris:
|
By
danielb987
· #4279
·
|
|
Codecov makes PRs more difficult to review
I try to review most new PRs, unless a review is requested from someone else. Lately, Codecov have started showing warnings in the code when reviewing a PR. As far as I can see, there is no way to get
|
I try to review most new PRs, unless a review is requested from someone else. Lately, Codecov have started showing warnings in the code when reviewing a PR. As far as I can see, there is no way to get
|
By
danielb987
· #4277
·
|
|
Min/max values for voltage/current meters for LcooNet, Z21, DCC++, Cbus?
Does anyone knows the minimum and maximum values of voltage and current meters for LocoNet, Z21, DCC++ and CBus? If you know the resolution too, it would be great, but it's not that important. DCC++ i
|
Does anyone knows the minimum and maximum values of voltage and current meters for LocoNet, Z21, DCC++ and CBus? If you know the resolution too, it would be great, but it's not that important. DCC++ i
|
By
danielb987
· #4272
·
|
|
Time to retire 'Store Configuration Only to File'?
Sorry, it should be: Have a preference setting there the user can choose between: * Never store on close * Always store on close * Ask the user on close Daniel 2020-08-28 18:47 skrev danielb987:
|
Sorry, it should be: Have a preference setting there the user can choose between: * Never store on close * Always store on close * Ask the user on close Daniel 2020-08-28 18:47 skrev danielb987:
|
By
danielb987
· #4254
·
|
