Mee to. Daniel 2020-08-05 01:29 skrev Dave Heap:

All, Please read #8865 and give your comments on it. Update github administration page to reflect current discussion https://github.com/JMRI/JMRI/pull/8865 Daniel

You could add a foot note like this: If a dispute cannot be resolved, the author of the PR may adress it on the JMRI developers mailing list. If needed, the owners of JMRI may merge the PR despite a r

Ok. I see what you mean. I approve your changes and I withdraw my suggestion. Daniel 2020-07-26 02:41 skrev Paul Bender:

I agree with the changes. As I wrote in the PR, I suggest an additional point in the section "Merging a PR": If there are a review requesting changes, but the author and the reviewer cannot resolve th

2020-07-24 19:39 skrev Paul Bender: Yes, sounds good. I agree. Daniel

Since Bob Jacobsen focuses on his signalling project which he deserves to do, it seems that there is no one merging other developers PRs at the moment. I'm afraid that the result is a big buildup of u

Paul I think you and I are on the same page, but we express it differently. I agree that there is PRs that never should be merged, and I may have been responsible for some of these. There are also PRs

If we have a list of who is "subject expert" on which part, it will be natural to request review from that person. If I see a new PR, I will check the list and if the PR affects one of the subjects on

2020-07-21 07:55 skrev Paul Bender: I think we need to have a plan on how to handle disagreements. If someone creates a PR and I disagree with it and do a bad review, but several others believe that t

2020-07-20 11:53 skrev Andrew Crosland: Some thoughts about testing: I start with writing tests for small simple methods. It's often easier to write tests for simple methods than complex ones, it give

Thanks. Please add links to the Javadoc of Jemmy. The link "Jemmy Javadoc" in the section "Using Jemmy" doesn't seem to work. Daniel 2020-07-20 14:53 skrev Paul Bender:

If I see a PR where Travis has failed and I think that the failure is not related to the PR itself, should I restart it or let the author of the PR restart it? One example is PR #8850 where Travis Hea

I fully agree on what you write. About peer review: I think it may work, but it requires that people are willing to do peer review, even on parts they don't fully understand. There are parts that only

2020-07-19 04:43 skrev Paul Bender: Yes, I think so. Daniel

I don't know, but I would try to uninstall OpenJDK and then try to download and install JDK from this page: https://www.oracle.com/java/technologies/javase-jdk11-downloads.html Daniel 2020-07-18 02:38

I think it would be good to have PR reviews. I'm not a maintainer, only a developer, but I try to read most of the PRs and there are three main reasons for me to do it: *) I learn a lot of Java, desig

I'm fine with this. I suggest that the "mergeable" bot prints a reminder of this in the PR, unless the PR already has one of these labels. The following paragraph may be good to include in that remind

Yes. See PR #8820 that fixes this package-file. https://github.com/JMRI/JMRI/pull/8820 It's ready to be merged once CI passes. Daniel 2020-07-10 21:08 skrev Bob Jacobsen:

I think I have a simple solution to both the problem of finding the problematic java file and the problem about checking it in CI: If I do a: mvn clean compile and then a: mvn -X compile | grep "Stale