toggle quoted messageShow quoted text
This is fixed in https://github.com/JMRI/JMRI/pull/7526
The problem is that in 2.7.1 Jython stopped shipping a library that apparently caused class loading conflicts in Java 9, but apparently we relied on earlier versions of Jython to provide for us.
On Oct 18, 2019, at 11:44 PM, Dave Heap <dgheap@...
Tried bisect again on a different Mac with different start points,
On 18 Oct 2019, at 9:32 PM, Dave Heap via Groups.Io <dgheap@...> wrote:
I'm getting a similar error with 'ant decoderpro' on my Mac on my local master up to date with origin master on a clean working tree. Tried Java 1.8.0_211, 1.8.0_221 and 1.8.0_231.
Git Bisect tells me:
27c1a9bed49c5ef8f9fa50a229c41bca7b5d3dd7 is the first bad commit
Author: Randall Wood <randall.h.wood@...>
Date: Sat Sep 21 10:40:25 2019 -0400
fa110c8a39 demonstrated that there is a problem running Jython 2.7.1 on Windows with JMRI as is. The next step is to figure out what changed between 2.7.0 and 2.7.1 that this only fails on Windows.
:100644 100644 2c49b05d9e8debf6c0bf2f2f5e7347ff3ebfdcf5 25fa05285d2f22b117a0c8178de408769b003509 M build.xml
:040000 040000 30822ca7c3d90e6ab354d594ec99659bb54f0e27 2cd42e51a12044bf017c66d69706e8f258ac914f M lib DecoderPro version 4.17.5ish+heap+20191019T0319Z+R27c1a9bed4 starts under Java 1.8.0_221 on Mac OS X x86_64 v10.12.6 at Sat Oct 19 14:19:13 AEDT 2019 [main]27c1a9bed49c5ef8f9fa50a229c41bca7b5d3dd7 is the first bad commitcommit 27c1a9bed49c5ef8f9fa50a229c41bca7b5d3dd7Author: Randall Wood <randall.h.wood@...>Date: Sat Sep 21 10:40:25 2019 -0400 revert fa110c8a39 fa110c8a39 demonstrated that there is a problem running Jython 2.7.1 on Windows with JMRI as is. The next step is to figure out what changed between 2.7.0 and 2.7.1 that this only fails on Windows. build.xml | 2 +- lib/jython-standalone-2.7.0.jar | Bin 37021723 -> 0 bytes 2 files changed, 1 insertion(+), 1 deletion(-) delete mode 100644 lib/jython-standalone-2.7.0.jarSame commit, rendered slightly differently.
Do you still want me to try this:
On 18 Oct 2019, at 11:00 PM, Randall Wood via Groups.Io <rhwood@...> wrote:
If `git bisect` is getting you to a commit where Jython 2.7.0 is replaced with Jython 2.7.1, please try replacing Jython 2.7.1 with 2.7.0 and see if that works (running from HEAD of master). If that does work, it suggests that Jython 2.7.0 included some code that we relied on that wasn’t expected.
If so, I assume that means:
- Edit build.xml.
- Delete the Jython 2.7.1 jar.
- Reinstate the Jython 2.7.0 jar (what is best way to do this with correct permissions etc.)?